codegen aws regions enums based on partitions.json #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
force-pushed
the
codegen-regions
branch
from
e8410cc
to
62f8f98
Compare
SergeyRyabinin
approved these changes
Jul 26, 2024
| @@ -16,44 +15,48 @@ namespace Aws | |||
| */ | |||
| namespace Region | |||
| { | |||
| // AWS_GLOBAL is a pseudo region that can be used to tell SDK to use the service global endpoint if there is any. | |||
There was a problem hiding this comment.
do you want to keep that comment about global?
There was a problem hiding this comment.
nah now that theres several global regions, and putting the global region as the first entry of the enum adds a bit of weird custom logic that makes this change a bit messy.
also existing AWS documentation on this exists that users could refer to.
aws-global specifies the global endpoint for services that support a separate global endpoint in addition to Regional endpoints, such as AWS Security Token Service (AWS STS) and Amazon Simple Storage Service (Amazon S3).
DmitriyMusatkin
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
issues/3057
Description of changes:
codegen
Region.henum from partitions.json instead of hand editing to prevent potential errors from hand editing adding new regions.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.